-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 2.44.0 #5242
Closed
Closed
release 2.44.0 #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #9790
Run Properties:
|
Project |
fides
|
Branch Review |
release-2.44.0
|
Run status |
Passed #9790
|
Run duration | 00m 38s |
Commit |
fec148431f: Fix CI, static_check and db_dataset.yml (#5255)
|
Committer | Andres Torres |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5242 +/- ##
==========================================
- Coverage 85.95% 76.83% -9.13%
==========================================
Files 363 366 +3
Lines 22955 23900 +945
Branches 3081 3305 +224
==========================================
- Hits 19732 18363 -1369
- Misses 2663 4927 +2264
- Partials 560 610 +50 ☔ View full report in Codecov by Sentry. |
* WIP commit - delay throwing errors on login. Create a fake user and attempt to parallelize operations so similar actions are performed on the fake user and the real user. This isn't possible for places where we need to write to the database. Further random delays are added to offset. * Create a fake user was more time consuming than the database call so bad user requests have become slower than good user requests. I've overcorrected. Instead, create the fake user upfront and hold it in memory. * Update changelog.
fides Run #9770
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5242/merge
|
Run status |
Passed #9770
|
Run duration | 00m 36s |
Commit |
2d5bd9251c ℹ️: Merge 657e3dd927915890d67e5d25c3c1567ebe8bc0bd into b7087620898c390a50e29cf7f052...
|
Committer | Roger Plotz |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Co-authored-by: Lucano Vera <[email protected]>
Co-authored-by: Lucano Vera <[email protected]>
- Adds a new purpose_header field on the ExperienceTranslation and on the historical record, the PrivacyExperienceConfigHistory table - Adds a data migration to populate purpose_header fields on all existing TCF translations as well as update the existing description, provided the customer is still on version 1 for that translation, meaning they've made no edits
* Added security for email templates that used Jinja2 * Added security for email templates that used Jinja2 * Added security for email templates that used Jinja2 * QA to migration * Update CHANGELOG.md * Update src/fides/api/alembic/migrations/versions/ff81f8e7d6ae_migrate_messaging_template_to_use_new_.py * QA * Update migrations
Kelsey-Ethyca
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Checklist
The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.
This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.
Additionally, there is a robust Release Process page available in Confluence (internal only).
Pre-Release Steps
General
From the release branch, confirm the following:
nox -s quickstart
(verify you can complete the interactive prompts from the command-line)nox -s "fides_env(test)"
(verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)Next, run the following checks via the test environment:
API
CLI
Run these from within the test environment shell:
git reset --hard
- Note: This is required for thepull
command to workfides user login
fides push src/fides/data/sample_project/sample_resources/
fides pull src/fides/data/sample_project/sample_resources/
fides evaluate src/fides/data/sample_project/sample_resources/
fides generate dataset db --credentials-id app_postgres test.yml
- Note: Because the filesystem isn't mounted, the new file will only show up within the containerfides scan dataset db --credentials-id app_postgres
Privacy Center
Admin UI
User Permissions
Documentation
Instead, they should be committed on a branch off of
main
and then PR'd and merged intomain
, before being cherry-pickedover to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and
main
.Publishing the release
When publishing the release, be sure to include the following sections in the release description:
## Release Pull Request
section that includes a link back to the release PR (i.e., this one!) for tracking purposes## QA Touch Test Run
section that includes a link to the QATouch test run (QA team should provide this)Post-Release Steps
python3 -m venv 2_12_0_venv
source 2_12_0_venv/bin/activate
pip install ethyca-fides
fides deploy up