Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.44.0 #5242

Closed
wants to merge 9 commits into from
Closed

release 2.44.0 #5242

wants to merge 9 commits into from

Conversation

Roger-Ethyca
Copy link
Contributor

@Roger-Ethyca Roger-Ethyca commented Aug 28, 2024

Release Checklist

The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.

This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.

Additionally, there is a robust Release Process page available in Confluence (internal only).

Pre-Release Steps

General

From the release branch, confirm the following:

  • Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line)
  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
  • Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

User Permissions

  • Verify user creation
  • Verify a Viewer can view all systems
  • Verify a Data Steward can edit systems they are assigned

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
  • ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 5:37pm

Copy link

cypress bot commented Aug 28, 2024

fides    Run #9790

Run Properties:  status check passed Passed #9790  •  git commit fec148431f: Fix CI, static_check and db_dataset.yml (#5255)
Project fides
Branch Review release-2.44.0
Run status status check passed Passed #9790
Run duration 00m 38s
Commit git commit fec148431f: Fix CI, static_check and db_dataset.yml (#5255)
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (9b2784f) to head (657e3dd).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/service/user/fides_user_service.py 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5242      +/-   ##
==========================================
- Coverage   85.95%   76.83%   -9.13%     
==========================================
  Files         363      366       +3     
  Lines       22955    23900     +945     
  Branches     3081     3305     +224     
==========================================
- Hits        19732    18363    -1369     
- Misses       2663     4927    +2264     
- Partials      560      610      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* WIP commit - delay throwing errors on login. Create a fake user and attempt to parallelize operations so similar actions are performed on the fake user and the real user.   This isn't possible for places where we need to write to the database.  Further random delays are added to offset.

* Create a fake user was more time consuming than the database call so bad user requests have become slower than good user requests. I've overcorrected. Instead, create the fake user upfront and hold it in memory.

* Update changelog.
Copy link

cypress bot commented Aug 29, 2024

fides    Run #9770

Run Properties:  status check passed Passed #9770  •  git commit 2d5bd9251c ℹ️: Merge 657e3dd927915890d67e5d25c3c1567ebe8bc0bd into b7087620898c390a50e29cf7f052...
Project fides
Branch Review refs/pull/5242/merge
Run status status check passed Passed #9770
Run duration 00m 36s
Commit git commit 2d5bd9251c ℹ️: Merge 657e3dd927915890d67e5d25c3c1567ebe8bc0bd into b7087620898c390a50e29cf7f052...
Committer Roger Plotz
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

pattisdr and others added 2 commits August 30, 2024 15:41
- Adds a new purpose_header field on the ExperienceTranslation and on the historical record, the PrivacyExperienceConfigHistory table
- Adds a data migration to populate purpose_header fields on all existing TCF translations as well as update the existing description, provided the customer is still on version 1 for that translation, meaning they've made no edits
* Added security for email templates that used Jinja2

* Added security for email templates that used Jinja2

* Added security for email templates that used Jinja2

* QA to migration

* Update CHANGELOG.md

* Update src/fides/api/alembic/migrations/versions/ff81f8e7d6ae_migrate_messaging_template_to_use_new_.py

* QA

* Update migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants